-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Fix Default command checkbox #7104
Merged
openshift-merge-robot
merged 2 commits into
redhat-developer:main
from
feloy:fix/ui-default-command-in-group
Oct 2, 2023
Merged
[ui] Fix Default command checkbox #7104
openshift-merge-robot
merged 2 commits into
redhat-developer:main
from
feloy:fix/ui-default-command-in-group
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
rm3l
reviewed
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Per https://github.com/redhat-developer/odo/actions/runs/6378286235/job/17308551518?pr=7104, the static files need to be regenerated ^^
rm3l
added
the
area/Dev-UI
Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder
label
Oct 2, 2023
Kudos, SonarCloud Quality Gate passed! |
rm3l
approved these changes
Oct 2, 2023
openshift-ci
bot
added
the
lgtm
Indicates that a PR is ready to be merged. Required by Prow.
label
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/Dev-UI
Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
Indicates that a PR is ready to be merged. Required by Prow.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #7103
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: